Final development version of the devloop. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeout and delay should now be implemented for the cluster. Have not had enough time to see if it works properly. The logic should be there though. The image is not exited but there is a condition for where it should. NOTE: Had to revert the previous version of this commit so it became a bit larger than expected. Now the rerun X times is in a dev-mode where after the tests pass a counter goes up, when the counter is larger than 3 it prints a message.
|
NOTE: It is important that env.json is present in the specs folder (in the ystack repo, not the one in kubernetes-assert). TIMEOUT: 0 | Timeout will not be used RERUN_TIME: X | Will run tests with a rerun time of X seconds. Without a json file it "should" work and the rerun time should be defaulted to 0 and timeout should be default to "infinity". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since my commit directly on the branch created conflicts we decided to make this PR instead. Commit notes below can be seen as an explanation but basically the three final steps of development has been implemented in this branch. The X reruns does not have all the functionality yet but delay should. Timeout "has" the functionality but does not exit the image? properly when timeout has been reached.
Commit notes:
Timeout and delay should now be implemented for the cluster. Have not had enough time to see if it works properly. The logic should be there though. The image is not exited but there is a condition for where it should.
NOTE: Had to revert the previous version of this commit so it became a bit larger than expected. Now the rerun X times is in a dev-mode where after the tests pass a counter goes up, when the counter is larger than 3 it prints a message.